Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Avoid stack overflow in filterFilter when using objects containing circular references - #7751

Closed
timschlechter wants to merge 1 commit into
angular:masterfrom
timschlechter:avoid_stackoverflow_in_filterfilter
Closed

timschlechter wants to merge 1 commit into
angular:masterfrom
timschlechter:avoid_stackoverflow_in_filterfilter

Conversation

@timschlechter

Copy link
Copy Markdown

When an object with a circular reference property is passed into the search function, a stack overflow occurs. This patch fixes this by processing only calls to objects not processed yet.

@mary-poppins

Copy link
Copy Markdown

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#7751)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@timschlechter timschlechter changed the title Avoid stack overflow in filterFilter when using objects containing circular refences Avoid stack overflow in filterFilter when using objects containing circular references Jun 9, 2014
@mary-poppins

Copy link
Copy Markdown

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@timschlechter

Copy link
Copy Markdown
Author

Ah, of course. I just submitted the CLA form

@mary-poppins

Copy link
Copy Markdown

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@caitp

caitp commented Jun 9, 2014

Copy link
Copy Markdown
Contributor

This is a dupe of #6319

@timschlechter

Copy link
Copy Markdown
Author

Ah, you're right. Closing this one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants